Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pollux): add anoncreds prooving implementation #106

Merged
merged 1 commit into from
Dec 20, 2023
Merged

feat(pollux): add anoncreds prooving implementation #106

merged 1 commit into from
Dec 20, 2023

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Nov 27, 2023 •
edited
Loading

Overview

This will add implementation so we can create presentation with a anoncred credential.

Fixes #ATL-5203

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to the above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to the above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to the above: I have added tests to cover my changes
  • If yes to the above: I have taken care to cover edge cases in my tests

elribonazo
elribonazo reviewed Nov 27, 2023
View reviewed changes
AtalaPrismSDK/Pollux/Sources/Models/AnonCreds/AnoncredsCredentialStack+ProvableCredential.swift
predicates: predicates
)
} else {
return try AnoncredsPresentation().createPresentation(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment or suggestion but is this if condition or else really needed?
computeAttributes and computePredicates will not process much if the arrays or object with attributes or predicates are empty right?

Could be wrong :)

Copy link
Contributor Author

@goncalo-frade-iohk goncalo-frade-iohk Nov 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah so the way I envision this logic was.

If the user provides ZKP Parameters then we don't do anything, if they wish to provide ZKP parameters with no attributes or predicates, its their option, so we don't compute them.

If the user doesn't provide ZKP parameters then we compute a "default" version based on the presentation request.

We can change this logic but it was what I envisioned

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-5203 branch 3 times, most recently from 48013d0 to 4128e98 Compare December 20, 2023 14:06
@goncalo-frade-iohk goncalo-frade-iohk merged commit 80377b1 into main Dec 20, 2023
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-5203 branch December 20, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

@elribonazo elribonazo elribonazo approved these changes

@curtis-h curtis-h Awaiting requested review from curtis-h

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goncalo-frade-iohk @elribonazo @hamada147